Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add e2e tests for multi-sort filter on experiments list #9968

Closed
wants to merge 8 commits into from
Closed

feat: add e2e tests for multi-sort filter on experiments list #9968

wants to merge 8 commits into from

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Sep 23, 2024 •
edited by jira bot
Loading

Ticket

ET-752

Description

This PR intends to add e2e tests for the multi-sort filter for the experiment list.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@thiagodallacqua-hpe thiagodallacqua-hpe requested a review from a team as a code owner September 23, 2024 17:45
@cla-bot cla-bot bot added the cla-signed label Sep 23, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a6f6366
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66f31e8b3ae5b600085cde67

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.43%. Comparing base (f758303) to head (487014f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9968      +/-   ##
==========================================
- Coverage   54.50%   50.43%   -4.08%     
==========================================
  Files        1255      946     -309     
  Lines      156733   128139   -28594     
  Branches     3601     3599       -2     
==========================================
- Hits        85424    64622   -20802     
+ Misses      71176    63384    -7792     
  Partials      133      133
Flag Coverage Δ
harness ?
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

@thiagodallacqua-hpe thiagodallacqua-hpe marked this pull request as draft September 23, 2024 17:46
JComins000
JComins000 suggested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you modify getOrder to be checkOrder instead for me?

webui/react/src/e2e/tests/experimentList.spec.ts Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
webui/react/src/e2e/tests/experimentList.spec.ts Outdated Show resolved Hide resolved
@thiagodallacqua-hpe thiagodallacqua-hpe force-pushed the thiago/ET-752 branch 2 times, most recently from 1373d0a to e448327 Compare September 24, 2024 19:56
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-752 branch October 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JComins000 JComins000 JComins000 requested changes

@ashtonG ashtonG Awaiting requested review from ashtonG

@johnkim-det johnkim-det Awaiting requested review from johnkim-det

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagodallacqua-hpe @JComins000